Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runservice: add tasks timeout #331

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

alessandro-sorint
Copy link
Contributor

@alessandro-sorint alessandro-sorint commented Mar 15, 2022

fix #6

runConfig: added TaskTimeout in global, run and task configuration
executor: added tasksTimeoutCleaner for managing task timeout
scheduler: updated executorTaskCleaner for managing task timeout and report it to the executor with a timeout signal in ExecutorTaskSpec

tests/setup_test.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/runservice/scheduler.go Outdated Show resolved Hide resolved
services/runservice/types/executortask.go Outdated Show resolved Hide resolved
services/runservice/types/executortask.go Outdated Show resolved Hide resolved
services/runservice/types/executortask.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint force-pushed the run-timeout branch 2 times, most recently from 6558982 to 4545f35 Compare May 27, 2022 08:28
@alessandro-sorint alessandro-sorint requested a review from sgotti May 27, 2022 08:30
@alessandro-sorint alessandro-sorint force-pushed the run-timeout branch 2 times, most recently from e9d84ca to 5b62de2 Compare May 27, 2022 12:06
@alessandro-sorint
Copy link
Contributor Author

@sgotti can you do the review please?

@alessandro-sorint alessandro-sorint force-pushed the run-timeout branch 4 times, most recently from be27700 to 4272219 Compare May 31, 2022 16:09
@alessandro-sorint
Copy link
Contributor Author

@sgotti can you do the review please?

internal/services/runservice/scheduler.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
tests/setup_test.go Show resolved Hide resolved
internal/services/runservice/scheduler.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/migration/runservice/types/types.go Outdated Show resolved Hide resolved
services/runservice/types/executortask.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint requested a review from sgotti June 7, 2022 11:36
@alessandro-sorint alessandro-sorint force-pushed the run-timeout branch 4 times, most recently from 63f81f4 to 32fb5c9 Compare June 9, 2022 14:05
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
services/runservice/types/executortask.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint force-pushed the run-timeout branch 2 times, most recently from eadf85f to b8dca5f Compare June 13, 2022 07:19
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
internal/services/executor/executor.go Outdated Show resolved Hide resolved
@alessandro-sorint
Copy link
Contributor Author

@sgotti can you do the review please?

internal/services/executor/executor.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint requested a review from sgotti July 15, 2022 09:21
@sgotti sgotti changed the title runservice: global and runconfig runs and tasks timeout runservice: add task timeout Jul 15, 2022
@alessandro-sorint alessandro-sorint changed the title runservice: add task timeout runservice: add tasks timeout Jul 15, 2022
config/runconfig: add fields to set task timeout at the global, run and task level

runservice/executor: handle tasks timeout
@sgotti sgotti merged commit 35b743e into agola-io:master Aug 1, 2022
@alessandro-sorint alessandro-sorint deleted the run-timeout branch August 2, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runservice: global and runconfig runs and tasks timeout
2 participants